Skip to content

Update import path and improve request validation - #3312

Open
rudrakshtank wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
rudrakshtank:issue3311
Open

Update import path and improve request validation#3312
rudrakshtank wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
rudrakshtank:issue3311

Conversation

@rudrakshtank

Copy link
Copy Markdown
Contributor

Summary

Closes #3311


Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that changes existing behavior)
  • 📝 Documentation update
  • ♻️ Refactor / code cleanup (no functional change)
  • ⚡ Performance improvement
  • 🔒 Security fix
  • 🧪 Tests only

Checklist

  • Linked the related issue above
  • Self-reviewed my own diff
  • No unnecessary console.log, debug code, or commented-out blocks
  • npm run lint passes locally
  • No TypeScript errors (npm run type-check)
  • Added or updated tests where applicable
  • Updated documentation / comments if behavior changed

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:testing GSSoC type bonus: tests (+10 pts) labels Jul 31, 2026
@github-actions

Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@Priyanshu-byte-coder

Copy link
Copy Markdown
Owner

Mixed bag — two changes are good, one needs justification, and CI is red.

Good:

  • Scoping the goals route to /\/api\/goals(\?|$)/ so it stops shadowing /api/goals/sync. That endpoint exists, so the old **/api/goals** glob was genuinely intercepting it.
  • Splitting the poll assertion into .toBeGreaterThanOrEqual(min) plus a separate .toBeLessThanOrEqual(max). Polling a boolean and asserting .toBe(true) gives you "expected true, got false" on failure, which tells you nothing. Your version reports the actual count. Good change.

Needs justification:

  • from "./helpers/dashboard-mocks""./helpers/dashboard-mocks.js". What does this fix? The import resolves as-is today, and dashboard-mocks.js is imported without the extension elsewhere. If it's working around a real resolution failure, please say which one in the description — otherwise it's inconsistent with the rest of the suite.

Red: Playwright smoke tests is failing on this branch. Worth checking whether it's the route-matching change or the extension change before this can go in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc26 GSSoC 2026 contribution type:testing GSSoC type bonus: tests (+10 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Fix ESM import resolution, route shadowing, and polling timeout anti-pattern

2 participants